freezed table name not working on association name

[mithrandirii]

hi,

i have an problem with the current master and freez table names. if i associate an model with freezed table name and an 's' (e.g. xyzs) at the end of the model name the association name in model.associations (e.g. model.associations.xyz) is without the s. but the s is not from pluralize, its my model/table name ?!

we use the current master of sequelize

mithrandir

[mickhansen]

Please show relevant code when posting an issue :)
You can alias relations with as to specify what name is used for the relation, by defualt it uses the model name. It will pluralize/singularlize depending on if its a :1 or :M relation.

[mithrandirii]

here is some test code, even if the used names make not realy sense ;)

var Sequelize = require('sequelize');

var sequelize = new Sequelize('test', 'root', 'linux', {
        dialect: 'mariadb',
        dialectOptions: {
                unixSocket: '/var/run/mysqld/mysqld.sock'
        },
        define: {
                charset: 'utf8',
                collate: 'utf8_general_ci',
                freezeTableName: true,
                underscored: true,
                timestamps: false
        }
});

Test = sequelize.define('BelegKopf', {
        id: {
                type: Sequelize.INTEGER.UNSIGNED,
                allowNull: false,
                primaryKey: true,
                autoIncrement: true
        },
        name: {
                type: Sequelize.STRING(30),
                validate: {
                        len: [1, 30] 
                }
        }
});

Xyzs = sequelize.define('Xyzs', {
        id: {
                type: Sequelize.INTEGER.UNSIGNED,
                allowNull: false,
                primaryKey: true,
                autoIncrement: true
        },
        price: {
                type: Sequelize.DECIMAL(5, 2), 
                validate: {
                        min: 0.01,
                        max: 100 
                }
        }
});

Test.hasOne(Xyzs, {
        foreignKey: 'test_id',
});
Xyzs.belongsTo(Test, {
        foreignKey: 'test_id',
});

console.log('test', Test.associations);

[mickhansen]

Please provide the output of the console.log aswell.

[mithrandirii]

test { Xyz: 
   { associationType: 'HasOne',
     source: 
      { options: [Object],
        name: 'BelegKopf',
        tableName: 'BelegKopf',
        rawAttributes: [Object],
        daoFactoryManager: [Object],
        associations: [Circular],
        scopeObj: {},
        primaryKeys: [Object],
        _timestampAttributes: {},
        autoIncrementField: 'id',
        primaryKeyAttributes: [Object],
        primaryKeyAttribute: 'id',
        primaryKeyCount: 1,
        hasPrimaryKeys: true,
        _hasPrimaryKeys: true,
        _isPrimaryKey: [Object],
        DAO: [Object],
        _readOnlyAttributes: [],
        _hasReadOnlyAttributes: 0,
        _isReadOnlyAttribute: [Object],
        _booleanAttributes: [],
        _dateAttributes: [],
        _hstoreAttributes: [],
        _defaultValues: {},
        _hasBooleanAttributes: false,
        _isBooleanAttribute: [Object],
        _hasDateAttributes: false,
        _isDateAttribute: [Object],
        _hasHstoreAttributes: false,
        _isHstoreAttribute: [Object],
        _hasDefaultValues: false },
     target: 
      { options: [Object],
        name: 'Xyzs',
        tableName: 'Xyzs',
        rawAttributes: [Object],
        daoFactoryManager: [Object],
        associations: [Object],
        scopeObj: {},
        primaryKeys: [Object],
        _timestampAttributes: {},
        autoIncrementField: 'id',
        primaryKeyAttributes: [Object],
        primaryKeyAttribute: 'id',
        primaryKeyCount: 1,
        hasPrimaryKeys: true,
        _hasPrimaryKeys: true,
        _isPrimaryKey: [Object],
        DAO: [Object],
        _readOnlyAttributes: [],
        _hasReadOnlyAttributes: 0,
        _isReadOnlyAttribute: [Object],
        _booleanAttributes: [],
        _dateAttributes: [],
        _hstoreAttributes: [],
        _defaultValues: {},
        _hasBooleanAttributes: false,
        _isBooleanAttribute: [Object],
        _hasDateAttributes: false,
        _isDateAttribute: [Object],
        _hasHstoreAttributes: false,
        _isHstoreAttribute: [Object],
        _hasDefaultValues: false },
     options: 
      { foreignKey: 'test_id',
        hooks: [Object],
        useHooks: false,
        timestamps: false,
        createdAt: 'createdAt',
        updatedAt: 'updatedAt',
        deletedAt: 'deletedAt',
        instanceMethods: {},
        classMethods: {},
        validate: {},
        freezeTableName: true,
        underscored: true,
        paranoid: false,
        whereCollection: null,
        schema: null,
        schemaDelimiter: '',
        language: 'en',
        defaultScope: null,
        scopes: null,
        charset: 'utf8',
        collate: 'utf8_general_ci',
        omitNull: false,
        uniqueKeys: {},
        hasPrimaryKeys: true,
        onDelete: 'SET NULL',
        onUpdate: 'CASCADE' },
     isSingleAssociation: true,
     isSelfAssociation: false,
     as: 'Xyz',
     identifier: 'test_id',
     sourceIdentifier: 'id',
     associationAccessor: 'Xyz',
     accessors: { get: 'getXyz', set: 'setXyz', create: 'createXyz' } } }

[mickhansen]

And how does it work for you if you use as: 'string'?

[mickhansen]

There's definitely an issue with it perceiving your model name to be plural. You might be able to solve this by aliasing the relation though.

[mithrandirii]

if i use the as statement in the association the name conflict is solved, but then i get an error on inlcude ...

var Sequelize = require('sequelize');

var sequelize = new Sequelize('test', 'root', 'linux', {
        dialect: 'mariadb',
        dialectOptions: {
                unixSocket: '/var/run/mysqld/mysqld.sock'
        },
        define: {
                charset: 'utf8',
                collate: 'utf8_general_ci',
                freezeTableName: true,
                underscored: true,
                timestamps: false
        }
});

Test = sequelize.define('Test', {
        id: {
                type: Sequelize.INTEGER.UNSIGNED,
                allowNull: false,
                primaryKey: true,
                autoIncrement: true
        },
        name: {
                type: Sequelize.STRING(30),
                validate: {
                        len: [1, 30] 
                }
        }
});

Xyzs = sequelize.define('Xyzs', {
        id: {
                type: Sequelize.INTEGER.UNSIGNED,
                allowNull: false,
                primaryKey: true,
                autoIncrement: true
        },
        price: {
                type: Sequelize.DECIMAL(5, 2), 
                validate: {
                        min: 0.01,
                        max: 100 
                }
        }
});

Test.hasOne(Xyzs, {
        foreignKey: 'test_id',
        as: 'Xyzs'
});
Xyzs.belongsTo(Test, {
        foreignKey: 'test_id'
});

Test.findAll({
        attributes: [
                'id',
                'name'
        ],
        include: {
                model: Xyzs,
                attributes: [
                        'id',
                        'name'
                ]
        }
}, {
        raw: true
}).success(function (result) {
        console.log('success')
}).error(function (err) {
        console.log('error', err);
});

.../node_modules/sequelize/lib/dao-factory.js:1531
      throw new Error(msg)
            ^
Error: Xyzs is not associated to Test!
    at module.exports.validateIncludedElement (.../node_modules/sequelize/lib/dao-factory.js:1531:13)
    at module.exports.validateIncludedElements (.../node_modules/sequelize/lib/dao-factory.js:1446:59)
    at module.exports.DAOFactory.findAll (.../node_modules/sequelize/lib/dao-factory.js:464:34)
    at Object.<anonymous> (.../test.js:56:6)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)

[mickhansen]

If you use as on a relation you need to use the same as on the include, as such:

Test.findAll({
        attributes: [
                'id',
                'name'
        ],
        include: {
                model: Xyzs,
                as: 'Xyzs',
                attributes: [
                        'id',
                        'name'
                ]
        }
});

Why are you using raw: true?

[mithrandirii]

ah, ok the as in the include statement does the trick.

thx, for your fast response and help !!

i used the 'raw: true' to speed up the query

[mickhansen]

I see, but i assume you don't get nested models then? What does the response look like when using raw: true?

[mithrandirii]

the response look like this ...

[
  {id: 1, name: 'test1', Xyzs: {id: 1, price: 12.43, test_id: 1},
  {id: 2, name: 'test1', Xyzs: {id: 2, price: 5.12, test_id: 2},
  {id: 3, name: 'test1', Xyzs: {id: 3, price: 57.02, test_id: 3}
]

[mickhansen]

Ah yeah, it's still doing the transform but it's not making it into models, yeah that will provide a performance benefit, and fine if going straight to API response.

[mithrandirii]

yes, we only use the raw for a rest interface for large paged grids which request 100 rows per page with a page count of 600k +.

for this grids we even have to transform it back from object to flat columns like the sql response, cause the grid does not understand nested objects. sequelize transforms it from flat aliased columns to nested objects and we transform it back ;). but the performance is very good. the only tricky thing is, if we associate an n:m, we get the same id in more than one row like in the left join results, so we limit to associate 1:1 for this grids.