flattenObject function throws uncaught error when it recursively flat…#10293
Merged
sushantdhiman merged 3 commits intosequelize:masterfrom Jan 2, 2019
Merged
Conversation
…tens objects and a value is null. Added a check to make sure the value is not null before recursively calling the flattenObject function again.
Contributor
|
Can you add a test for this? |
Codecov Report
@@ Coverage Diff @@
## master #10293 +/- ##
==========================================
+ Coverage 96.27% 96.28% +0.01%
==========================================
Files 68 68
Lines 9772 9772
==========================================
+ Hits 9408 9409 +1
+ Misses 364 363 -1
Continue to review full report at Codecov.
|
SimonSchick
approved these changes
Dec 26, 2018
Contributor
Author
|
@SimonSchick Tests written |
sushantdhiman
approved these changes
Jan 2, 2019
Contributor
|
Thanks @skellertor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tens objects and a value is null. Added a check to make sure the value is not null before recursively calling the flattenObject function again.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Added an additional check for null when flattening objects in the util.js file. Since null is a
typeofobject, the function would call itself and try to use theObject.keysfunction on null, which would then throw an error that was covering a validation error.