Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): specified `this` for getters and setters in fields #11648

merged 1 commit into from Nov 9, 2019


Copy link

knoid commented Nov 5, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Added typings for this on getters and setters in attribute definitions.


This comment has been minimized.

Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #11648 into master will increase coverage by 3.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11648      +/-   ##
+ Coverage   92.47%   95.86%   +3.38%     
  Files          91       91              
  Lines        8903     8987      +84     
+ Hits         8233     8615     +382     
+ Misses        670      372     -298
Impacted Files Coverage Δ
lib/dialects/mariadb/query-generator.js 14.28% <0%> (-85.72%) ⬇️
lib/dialects/mariadb/data-types.js 50.98% <0%> (-49.02%) ⬇️
lib/dialects/sqlite/index.js 100% <0%> (ø)
lib/dialects/sqlite/query.js 98.65% <0%> (ø)
lib/dialects/sqlite/connection-manager.js 100% <0%> (ø)
lib/data-types.js 91.34% <0%> (+0.34%) ⬆️
lib/dialects/abstract/query-generator.js 97.01% <0%> (+0.51%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbef15f...2237276. Read the comment docs.

@sushantdhiman sushantdhiman merged commit afb8cc3 into sequelize:master Nov 9, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing cbef15f...2237276
codecov/project 95.86% (+3.38%) compared to cbef15f
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.