feat(query-generator): Generate UPDATEs using bind parameters #9492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazoakley
force-pushed
the
feat-update-bind
branch
from
c8b94c1 to
52aecbc
Compare
gazoakley
force-pushed
the
feat-update-bind
branch
from
52aecbc to
d9cf786
Compare
gazoakley
force-pushed
the
feat-update-bind
branch
3 times, most recently
from
62ec295 to
432f567
Compare
gazoakley
changed the title
test/integration/data-types.test.js
Outdated
| const Type = new Sequelize.STRING(); | ||
|
|
||
| if (dialect === 'mssql') { |
There was a problem hiding this comment.
mssql has a _bindParam function that outputs either a Buffer or a normal string dependent on whether or not the STRING data type uses the binary param. This override isn't needed for other dialects - I've added a comment.
| @@ -984,8 +984,8 @@ describe(Support.getTestDialectTeaser('Model'), () => { | |||
| return user.save({ | |||
| logging(sql) { | |||
| test = true; | |||
| expect(sql).to.contain('ARRAY[]::INTEGER[]'); | |||
| expect(sql).to.contain('ARRAY[]::VARCHAR(255)[]'); | |||
| expect(sql).not.to.contain('ARRAY[]::INTEGER[]'); | |||
There was a problem hiding this comment.
These tests should be moved to unit tests, but that is too much work, should be tackled in different PR. Please add some assertion which covers what is expected here, like may be just ARRAY[]?
There was a problem hiding this comment.
janmeier
approved these changes
Jun 5, 2018
gazoakley
force-pushed
the
feat-update-bind
branch
from
432f567 to
207c6d3
Compare
sushantdhiman
approved these changes
Jun 5, 2018
|
@sushantdhiman @janmeier Thanks 🎉 |
|
Thanks for this contribution @gazoakley , This is an important missing feature from Sequelize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Changes to allow UPDATEs to use bind parameters instead of directly included values. For example, instead of:
UPDATE `myTable` SET `name`='foo',`birthday`='2011-03-27 10:01:55' WHERE `id` = 2Generate:
UPDATE `myTable` SET `name`=$1,`birthday`=$2 WHERE `id` = $3(with parameters
'foo','2011-03-27 10:01:55'and2)