Clean the Monero lib for auditing #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayabaNerve
added
improvement
Also bifurcates prove with prove_plus, and adds a few documentation items.
Also adds a bit more documentation and does a bit more tidying.
It's a notable bandwidth/performance improvement, yet it's not ready. We need a dedicated Distribution struct which is managed by the wallet and passed in. While we can do that now, it's not currently worth the effort.
Abstracts the types used internally. Also moves the tests from monero-serai to monero-clsag.
Removes usage of dalek-ff-group/multiexp for curve25519-dalek. Makes compiling in the generators an optional feature. Adds a structured batch verifier which should be notably more performant. Documentation and clean up still necessary.
I still don't like the impl of the original Bulletproofs...
Also adds a helper to fetch a transaction's prefix.
…er/GuaranteedScanner Also cleans the Scanner impl.
Guaranteed addresses are in fact guaranteed even with this due to prefixing key images causing zeroing the ECDH to not zero the shared key.
This was done by requiring the system's usize can represent a certain number.
Unfortunately, this test is still failing.
Finally fixes the lack of decoy candidates failures in CI.
Change made due to a segfault incurred when locally testing. monero-project/monero#9141 for the upstream.
Adds a minimum XMR fee to the processor and runs fmt.
I'm truly unsure why this is required right now.
If there's no change, the fee is difference of the inputs to the outputs. The prior code wouldn't check that amount is greater than or equal to the necessary fee, and returning the would-be change amount as the fee isn't necessarily helpful. Now the fee is validated in such cases and the necessary fee is returned, enabling operating off of that.
|
I'm willing to handle the rest in commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs:
Yet it is time to start running the CI again.