This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Fix for comments with brackets inside arrays #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bfccaf58535f1dd44fed57cfb324f2781b2dc7cc)
|
Hi thanks , I will check and include this for the next version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again! I came across a crate (
Hyper) which didn't parse properly so I tracked that down. The issue was that comments were not being handled at all within arrays - and so they fell into the unhandledelsewhich allowed parsing of the commented-brackets.I also made a function for
isCommentand removed an unusedifbranch.Fixes #114