Specialize parser for Iter=&[u8] #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some contortions to keep the new |
| { | ||
| for (s, err) in errors { | ||
| match (err, from_str::<T>(s).unwrap_err()) { | ||
| for &(s, ref err) in &errors { |
There was a problem hiding this comment.
This is because Error is not Copy or Clone so I need a reference in order to test both the error from from_str and the one from from_iter.
|
Those improvements are impressive. Code looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves parser performance by 30-60% (that's right, more than 2x faster for many inputs). Performance when reading from other types of iterators is not affected.
The tests are going to require a Serde release containing serde-rs/serde#422 and serde-rs/serde#423.