Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit test for the httpInterceptor, multiple cases. #4

Open
ceoaliongroo opened this issue Apr 15, 2014 · 10 comments
Open

Create unit test for the httpInterceptor, multiple cases. #4

ceoaliongroo opened this issue Apr 15, 2014 · 10 comments

Comments

@ceoaliongroo
Copy link

Describe for the httpInterceptor, the unit test for different URL and Methods, also compatibility of work with other interceptors or external data services like firebase, simperium, parse, etc.

Example:
GET, http://server/api/test
POST, http://server/api/test/new
DELETE, http://production.firebase.io/api/test/1
PUT, http://server/api/test/4
GET, /api/test
GET, /test

My specific case, i have a http interceptor that include the base server uri. This need compatibility.

@seriema seriema added this to the 0.1.0 milestone Apr 17, 2014
@seriema
Copy link
Owner

seriema commented Apr 26, 2014

@ceoaliongroo are you happy with the commit or did you mean something else?

@ceoaliongroo
Copy link
Author

I don't know, i want to research little more about best practices of test for http interceptors.

It's ok for you? leave open the issue open

@seriema
Copy link
Owner

seriema commented Apr 27, 2014

Ok, I'll leave this to you then. Thanks!

@seriema
Copy link
Owner

seriema commented May 19, 2014

I have changed the tests so now it's only full tests from the "outside". Maybe it should be called E2E tests? Anyway, I have included GET/PUT/POST/DELETE. Take a look if that's what you meant so we can try to close this.

@seriema
Copy link
Owner

seriema commented Oct 19, 2014

@ceoaliongroo are you still interested in doing this?

@ceoaliongroo
Copy link
Author

thanks for ask @seriema, i don't know if is worthy; also many changes into angular, Do you think it's necessary?

@seriema
Copy link
Owner

seriema commented Oct 19, 2014

@ceoaliongroo Those tests would be useful. Not sure what you mean by the changes in angular? Do you mean the new 1.3?

@ceoaliongroo
Copy link
Author

yes the new version, angularjs 1.3

@seriema
Copy link
Owner

seriema commented Oct 19, 2014

@ceoaliongroo Not sure what changed with 1.3 that changes apiMock? The httpInterceptor interface looks the same.

@seriema
Copy link
Owner

seriema commented Oct 19, 2014

I just tried the code with 1.3 and it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants