Skip to content

Fallback RequestPath for when IHttpRequestFeature.RawTarteg is empty #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2020
Merged

Fallback RequestPath for when IHttpRequestFeature.RawTarteg is empty #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd539d
Fallback RequestPath for when IHttpRequestFeature.RawTarteg is empty …
rsantosdev Apr 30, 2020
4fea465
Using string.IsNullOrEmpty / Adding extra comments
rsantosdev Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Serilog.AspNetCore/AspNetCore/RequestLoggingMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,18 @@ static double GetElapsedMilliseconds(long start, long stop)

static string GetPath(HttpContext httpContext)
{
return httpContext.Features.Get<IHttpRequestFeature>()?.RawTarget ?? httpContext.Request.Path.ToString();
/*
In some cases, like when running integration tests with WebApplicationFactory<T>
the RawTarget returns an empty string instead of null, in that case we can't use
?? as fallback.
*/
var requestPath = httpContext.Features.Get<IHttpRequestFeature>()?.RawTarget;
if (string.IsNullOrEmpty(requestPath))
{
requestPath = httpContext.Request.Path.ToString();
}

return requestPath;
}
}
}