-
Notifications
You must be signed in to change notification settings - Fork 10
Update to RC2 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @merbla |
}, | ||
"frameworks": { | ||
"net45": { | ||
"net4.5": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so - all of the new TFMs seem to use this pattern. Works for https://github.com/serilog/serilog/blob/dev/src/Serilog/project.json#L16, anyway :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. That's really weird. Why would they change existing TFMs? Not even MS themselves use that style; https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNetCore.Server.Kestrel/project.json#L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And right below, where it lists the NuGet identifiers, it's lists the good old; .NET Framework 2.0 - 4.6 -> net20 - net46 😝 Anyway... As long as it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe :-) .. yeah! I'm just desperate for a bit of sanity/consistency, so happy if they support the dotted names throughout 👍
?
(Assuming a "yes" ;-) ) .. need to get this out to unblock upgrading serilog-settings-configuration. |
No description provided.