Brought output template text color into line with previous literate theme #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Jun 19, 2017
| { | ||
| var _ = 0; | ||
| using (_theme.Apply(output, ConsoleThemeStyle.SecondaryText, ref _)) | ||
| using (_theme.Apply(output, ConsoleThemeStyle.TertiaryText, ref _)) |
There was a problem hiding this comment.
This one is the actual change; the other diff points are caused by the enum item rename.
|
Might just push this one through, trivial change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Punctuation in structured data and text embedded in the output template share a color in the current literate console sink (generally, literal text in the output template is punctuation). This brings the new sink back into line with the older one.