Skip to content

Conversation

sermojohn
Copy link
Owner

@sermojohn sermojohn commented Aug 25, 2022

Both flag library and this module was logging the errors coming from flag commands, so it was confusing.

Removed logging of flag errors from this module.

@sermojohn sermojohn self-assigned this Aug 25, 2022
@sermojohn sermojohn force-pushed the log-command-error-once branch from 082198d to 1588d90 Compare August 25, 2022 16:31
@coveralls
Copy link

coveralls commented Aug 25, 2022

Pull Request Test Coverage Report for Build 2928217883

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.647%

Totals Coverage Status
Change from base Build 2928207472: 0.0%
Covered Lines: 445
Relevant Lines: 532

💛 - Coveralls

@sermojohn sermojohn changed the title fix: log command error once fix: logging errors once Aug 25, 2022
@sermojohn sermojohn changed the title fix: logging errors once fix: log errors once Aug 25, 2022
@sermojohn sermojohn merged commit 83a192c into main Aug 25, 2022
@sermojohn sermojohn deleted the log-command-error-once branch August 25, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants