Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rationalize get_band_path functions #31

Open
remi-braun opened this issue Apr 8, 2022 · 4 comments
Open

ENH: Rationalize get_band_path functions #31

remi-braun opened this issue Apr 8, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@remi-braun
Copy link
Member

It could be great to rationalize all the functions that gravite around get_band_path, and see which one needs to be public or private.
The actual issue is that this function orthorectifies, reprojects in UTM or geocodes the arrays under the hood, which can be time consuming and not desired.

So it could be better to disambiguate these function names:

  • get_band_path: Main function that orthorectifies, reprojects in UTM or geocodes the arrays under the hood.
  • get_existing_band_paths: Get all the paths for all the existing bands and relies on get_band_path
  • get_default_band_path: Get the path of the default band and relies on get_band_path
  • _get_raw_band_paths: Get the raw band file path, SAR only. This may need to be made public and generalized to optical data ?

Other sensor specific function that may need to be grouped or generalized:

  • _get_preprocessed_band_path: Get the path of preprocessed Sentinel-3 data
  • _get_utm_band_path: Get the reproject/orthorectified the VHR bands to UTM

Other functions managing paths but which don't pose any problem:

  • _get_clean_band_path: Get the path for cleaned data, optical only.
  • _get_cloud_band_path: Get the path for cloud data written on disk, optical only.

If no clearer way of managing this is found, at least an update in the documentation is needed.

@remi-braun remi-braun added the enhancement New feature or request label Apr 8, 2022
@remi-braun remi-braun changed the title ENH: Rationalize ge_band_path functions ENH: Rationalize get_band_path functions Apr 8, 2022
@remi-braun
Copy link
Member Author

Manage raw band files in a better way, for example using a regex and factorizing the code.

remi-braun added a commit that referenced this issue May 5, 2022
…vocabulary**

- **ENH: Add a STAC object that can be used to retrieve STAC Items from every Product (`prod.stac.create_item()`)**
- **ENH: Extending `get_raw_band_paths` to every products ([#31](#31
- **ENH: Adding a `is_ortho` attribute corresponding to when the product is already orthorectified/geocoded, in order to avoid computing heavy processes without wanting it (i.e. footprint...)**
- OPTIM: Retrieve extent from metadata when possible
@remi-braun
Copy link
Member Author

get_raw_band_paths becomes public and is generalized to all products.

@remi-braun
Copy link
Member Author

get_raw_band_paths becomes public and is generalized to all products.

This must be documented (i.e. in VHR/SAR notebooks)

@remi-braun
Copy link
Member Author

💡 It would also be nice to be able to retrieve all the band paths (spectral bands, but also DEM, clouds and spectral indices) with get_band_paths
➡️ One big question though for get_band_paths alignement: should it compute the paths asked (copied on non-ortho bands)
🔗 From #80

bastiencyr pushed a commit to bastiencyr/eoreader that referenced this issue May 30, 2023
…vocabulary**

- **ENH: Add a STAC object that can be used to retrieve STAC Items from every Product (`prod.stac.create_item()`)**
- **ENH: Extending `get_raw_band_paths` to every products ([sertit#31](sertit#31
- **ENH: Adding a `is_ortho` attribute corresponding to when the product is already orthorectified/geocoded, in order to avoid computing heavy processes without wanting it (i.e. footprint...)**
- OPTIM: Retrieve extent from metadata when possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant