-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Rationalize get_band_path functions #31
Comments
Manage raw band files in a better way, for example using a regex and factorizing the code. |
…vocabulary** - **ENH: Add a STAC object that can be used to retrieve STAC Items from every Product (`prod.stac.create_item()`)** - **ENH: Extending `get_raw_band_paths` to every products ([#31](#31 - **ENH: Adding a `is_ortho` attribute corresponding to when the product is already orthorectified/geocoded, in order to avoid computing heavy processes without wanting it (i.e. footprint...)** - OPTIM: Retrieve extent from metadata when possible
|
This must be documented (i.e. in VHR/SAR notebooks) |
💡 It would also be nice to be able to retrieve all the band paths (spectral bands, but also DEM, clouds and spectral indices) with |
…vocabulary** - **ENH: Add a STAC object that can be used to retrieve STAC Items from every Product (`prod.stac.create_item()`)** - **ENH: Extending `get_raw_band_paths` to every products ([sertit#31](sertit#31 - **ENH: Adding a `is_ortho` attribute corresponding to when the product is already orthorectified/geocoded, in order to avoid computing heavy processes without wanting it (i.e. footprint...)** - OPTIM: Retrieve extent from metadata when possible
It could be great to rationalize all the functions that gravite around
get_band_path
, and see which one needs to be public or private.The actual issue is that this function orthorectifies, reprojects in UTM or geocodes the arrays under the hood, which can be time consuming and not desired.
So it could be better to disambiguate these function names:
get_band_path
: Main function that orthorectifies, reprojects in UTM or geocodes the arrays under the hood.get_existing_band_paths
: Get all the paths for all the existing bands and relies onget_band_path
get_default_band_path
: Get the path of the default band and relies onget_band_path
_get_raw_band_paths
: Get the raw band file path, SAR only. This may need to be made public and generalized to optical data ?Other sensor specific function that may need to be grouped or generalized:
_get_preprocessed_band_path
: Get the path of preprocessed Sentinel-3 data_get_utm_band_path
: Get the reproject/orthorectified the VHR bands to UTMOther functions managing paths but which don't pose any problem:
_get_clean_band_path
: Get the path for cleaned data, optical only._get_cloud_band_path
: Get the path for cloud data written on disk, optical only.If no clearer way of managing this is found, at least an update in the documentation is needed.
The text was updated successfully, but these errors were encountered: