Skip to content

Conversation

SimonSimCity
Copy link
Contributor

@SimonSimCity SimonSimCity commented Dec 22, 2017

In the IstanbulJS API package, the transformer-method https://github.com/istanbuljs/istanbuljs/pull/99/files#diff-e0c7058aa9756c4cb034603b8e01b783R57 required some changes. Likewise this package will have to adapt to the new call of the runInThisContext() method. This is a simple way to support both the old and the new variant.

This will fix the error mentioned in #54 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.0% when pulling 49ae8d8 on SimonSimCity:feature/update-lib-istanbul into 2bdb456 on serut:bugfix/repair-tests.

@SimonSimCity SimonSimCity changed the base branch from bugfix/repair-tests to master December 22, 2017 09:34
@SimonSimCity SimonSimCity changed the title Compatibility to IstanbulJS PR #99 Update IstanbulJS and add compatibility to the PR #99 Dec 22, 2017
@SimonSimCity
Copy link
Contributor Author

After istanbuljs/istanbuljs#99 has been approved this PR can safely be merged. It is also backwards compatible to older versions of Meteor, where runInThisContext() was called in the old way.

@serut
Copy link
Owner

serut commented Mar 1, 2018

Looks like istanbuljs have merged that pull request. All these PR will be merged asap.
Thanks for your huge investment @SimonSimCity !

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fd36541). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #60   +/-   ##
======================================
  Coverage          ?   78%           
======================================
  Files             ?     1           
  Lines             ?    50           
  Branches          ?     0           
======================================
  Hits              ?    39           
  Misses            ?    11           
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd36541...fd4fb21. Read the comment docs.

@SimonSimCity
Copy link
Contributor Author

I've updated the package as described in istanbuljs/istanbuljs#143 and can confirm that this branch now works without any further modifications on Meteor 1.6.1 🎉

@serut serut merged commit fd4fb21 into serut:master Mar 6, 2018
@SimonSimCity SimonSimCity deleted the feature/update-lib-istanbul branch March 7, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants