Skip to content
This repository was archived by the owner on Oct 26, 2021. It is now read-only.

Conversation

fussel178
Copy link
Member

Added

  • system information wrapped from systeminformation npm module.
  • options parsing to specify result by define function names from systeminformation reference and filter options (see (README.md))
  • unit tests to reach 100% code coverage

Changed

nothing

Notes

  • the functions si.time() and si.version() are non promise function but do not break the await statement in the code. Interesting

@fussel178 fussel178 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 5, 2019
@fussel178 fussel178 requested a review from pklaschka October 5, 2019 17:09
@fussel178 fussel178 self-assigned this Oct 5, 2019
@fussel178 fussel178 added this to the v0.1.0 milestone Oct 5, 2019
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just the JSDoc comment is a bit off (see my inline-comment regarding that). Other than that, I think it's good (more on that later this evening, I didn't have enough time right now)

@fussel178 fussel178 requested a review from pklaschka October 5, 2019 18:12
@fussel178 fussel178 merged commit 43dc841 into master Oct 5, 2019
@fussel178 fussel178 deleted the develop branch October 5, 2019 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants