Add missing unit tests which cover package individually scenario. #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperBrain
requested changes
Nov 5, 2017
tests/validate.test.js
Outdated
| globSyncStub.callsFake(filename => [_.replace(filename, '*', 'js')]); | ||
| return expect(module.validate()).to.be.fulfilled | ||
| .then(() => { | ||
| expect(module.webpackConfig.length).to.equal(4); |
There was a problem hiding this comment.
Could be expressed as expect(module.webpackConfig).to.have.lengthOf(4); which will implicitly check for an array like structure.
HyperBrain
approved these changes
Nov 5, 2017
|
@ceilfors Just recognized that this breaks the unit tests on Windows (because of the fixed |
HyperBrain
pushed a commit
that referenced
this pull request
Nov 15, 2017
|
Committed and fixed |
|
@HyperBrain Apologies! Maybe it's a good idea to add Windows to travis? |
|
@ceilfors Yes, I planned to add AppVeyor as second build machine for the unit tests |
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Add missing unit tests which cover package individually scenario.
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
When trying to help on #266, I discovered that the plugin has 0% coverage at the moment for
service.package.individuallyoption in validate.js. This PR adds more unit tests for the missing coverage.How did you implement it:
Unit tests are written.
How can we verify it:
Clone branch, run the test.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO