-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Added aws-node-heroku-postgres example. #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eahefnawy
merged 4 commits into
serverless:master
from
mattwelke:adding-aws-node-heroku-postgres
Jan 15, 2019
Merged
Added aws-node-heroku-postgres example. #349
eahefnawy
merged 4 commits into
serverless:master
from
mattwelke:adding-aws-node-heroku-postgres
Jan 15, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't forget to run |
@sebito91 Done! |
dschep
approved these changes
Jan 14, 2019
pmuens
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this example for a blog post when experimenting with connecting AWS Lambda (us-east-1 region) and Heroku Postgres (in the United States region) together for a free tier serverless app that used PostgreSQL as its data layer. When I shared the blog post on the Slack channel of my local Serverless group, they suggested I add it to the official examples repo.
Feel free to let me know if there are any style changes etc to make to help it fit in in this repo.
Side note: As per the PR guide, I ran
npm run lint
but it returned exit code 1 because a lot of the examples already in here already don't pass linting, for example by having 12 space indentation in areas instead of 4.