Skip to content

Conversation

bao1018
Copy link
Contributor

@bao1018 bao1018 commented Mar 29, 2020

This PR is going to fix below issue:
#202

@bao1018 bao1018 requested a review from medikoo March 29, 2020 06:18
@bao1018 bao1018 changed the title Fix #202: google api v1 migration issue Fix #202: Cloud function migration issue when update to Google v1 api Mar 29, 2020
@bao1018 bao1018 changed the title Fix #202: Cloud function migration issue when update to Google v1 api Cloud function migration issue when update to Google v1 api Mar 29, 2020
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bao1018 thanks for PR!

Still shouldn't we just do following:

  1. Revert #165
  2. Publish v2.4.3
  3. Take #165 again
  4. Publish as v3.0.0

?

@bao1018
Copy link
Contributor Author

bao1018 commented Mar 30, 2020

@medikoo I am confused from here, I think we just release a new version base upon #165, why do we need this process ?

  1. Revert Migrate to CloudFunctions v1 API. #165
  2. Publish v2.4.3
  3. Take Migrate to CloudFunctions v1 API. #165 again
  4. Publish as v3.0.0

@medikoo
Copy link
Contributor

medikoo commented Mar 30, 2020

@medikoo I am confused from here, I think we just release a new version base upon #165, why do we need this process ?

I believe that #165 was a breaking change, that we've published with patch update, when it should have been published with a major bump.

Or wasn't that a breaking change in your opinion?

Note this package respects semver

@bao1018
Copy link
Contributor Author

bao1018 commented Mar 30, 2020

@medikoo we just found some issues in this PR after some regression test, I will close this PR first

@bao1018 bao1018 closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants