This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fixes 'Unable to read handler file in function' error for Java runtime #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138
In the base class base.js function
getArtifactZip
, we already read the zipfile into a bufferserverless-openwhisk/compile/functions/runtimes/base.js
Line 83 in 7ffcbef
processActionPackage
function, in this case in java.jsserverless-openwhisk/compile/functions/runtimes/java.js
Line 36 in 7ffcbef
zip
parameter is aJSZip
object, thus it all fails with a NPE sincezip.file
does not evaluate. We just need toreturn zip
in the function.On a cursory review, I think other runtimes may make this mistake as well I think: https://github.com/serverless/serverless-openwhisk/search?q=processActionPackage&unscoped_q=processActionPackage