Skip to content

Add pipCmdExtraArgs property. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2017
Merged

Add pipCmdExtraArgs property. #47

merged 1 commit into from
Jul 29, 2017

Conversation

rmax
Copy link
Contributor

@rmax rmax commented Jul 26, 2017

This allows to add extra pip arguments. For example, I'm using this feature to enable the cache directory:

custom:
  pythonRequirements:
      dockerizePip: true
      pipCmdExtraArgs:
          - --cache-dir
          - .requirements-cache

Let me know if the approach looks good (property naming, arguments as array).

dschep
dschep suggested changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the PR! I just ask that you add a little note about it in README.md as well 😉

@dschep dschep mentioned this pull request Jul 28, 2017
Merged
@dschep dschep merged commit 4abd1ab into serverless:master Jul 29, 2017
dschep added a commit that referenced this pull request Jul 29, 2017
@dschep
document #47
6e37aef
@rmax rmax changed the title [WIP] Add pipCmdExtraArgs property. Add pipCmdExtraArgs property. Jul 29, 2017
@rmax
Copy link
Contributor Author

rmax commented Jul 29, 2017

Oh, cool! Thanks for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dschep dschep dschep requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmax @dschep