Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a . while loading (instead of implementing a spinner) #1446

Closed
pmuens opened this issue Jun 29, 2016 · 6 comments
Closed

Print a . while loading (instead of implementing a spinner) #1446

pmuens opened this issue Jun 29, 2016 · 6 comments
Assignees
Milestone

Comments

@pmuens
Copy link
Contributor

pmuens commented Jun 29, 2016

We should append a . in the terminal while Serverless is loading / doing it's thing (e.g. deploy a CloudFormation stack) instead of printing a message each time.

@pmuens pmuens added this to the v1.0 milestone Jun 29, 2016
@pmuens
Copy link
Contributor Author

pmuens commented Jul 1, 2016

This might help with the implementation:
http://stackoverflow.com/a/11600998

Otherwise we can print a ., use the readline module to see how many . are already printed (e.g. 4) and then just add another . and repeat. This way we don't have to keep variable to store how many . are already printed..

@flomotlik
Copy link
Contributor

So for a first simple implementation we could create a short method that prints a message first and then in a defined timeframe prints . . . . . .

So e.g.

Waiting for Cloudformation deployment . . . . . . . . . . . . . . . 

What do you guys think about this? @tobyhede would be interesting to get your opinion

@flomotlik
Copy link
Contributor

Imho this should work for the implementation: process.stdout.write(chalk.yellow('.'));

@pmuens
Copy link
Contributor Author

pmuens commented Jul 28, 2016

Sounds like a good, minimalistic solution! 👍

@eahefnawy
Copy link
Member

Yep that should work 💃

@pmuens pmuens added easy-pick and removed area/cli labels Aug 1, 2016
@pmuens pmuens self-assigned this Aug 3, 2016
@pmuens pmuens modified the milestones: v1.0.0-beta.2, v1.0 Aug 4, 2016
@pmuens
Copy link
Contributor Author

pmuens commented Aug 4, 2016

Will be resolved with #1755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants