New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google-cloudfunctions to v2 and set defaults to node8 etc #5311

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
4 participants
@bodaz
Copy link
Contributor

bodaz commented Sep 18, 2018

What did you implement:

Upgraded the google-nodejs template's serverless-google-cloudfunctions dependecy to v2 and default Node to v8, also matchs the configs of serverless.yaml to the default values from the tests

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens

pmuens approved these changes Jan 23, 2019

Copy link
Member

pmuens left a comment

This looks good! Thanks for updating this @bodaz 👍

I just resolved to conflicts and it's now GTM :shipit:

@pmuens pmuens added this to In progress in Serverless via automation Jan 23, 2019

@pmuens pmuens self-assigned this Jan 23, 2019

@pmuens pmuens merged commit e5d4b4f into serverless:master Jan 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.004%
Details

Serverless automation moved this from In progress to Done Jan 23, 2019

@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019

@shortjared shortjared added docs enhancement and removed docs labels Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment