Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade google-cloudfunctions to v2 and set defaults to node8 etc #5311

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Upgrade google-cloudfunctions to v2 and set defaults to node8 etc #5311

merged 2 commits into from
Jan 23, 2019

Conversation

boda-sh
Copy link
Contributor

@boda-sh boda-sh commented Sep 18, 2018

What did you implement:

Upgraded the google-nodejs template's serverless-google-cloudfunctions dependecy to v2 and default Node to v8, also matchs the configs of serverless.yaml to the default values from the tests

Is this ready for review?: YES
Is it a breaking change?: NO

pmuens
pmuens approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for updating this @BODAZ 👍

I just resolved to conflicts and it's now GTM :shipit:

@pmuens pmuens self-assigned this Jan 23, 2019
@pmuens pmuens merged commit e5d4b4f into serverless:master Jan 23, 2019
@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees

@pmuens pmuens

Labels
enhancement
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@boda-sh @pmuens @horike37 @shortjared