fix(109): split foreach state to separate file #118
Conversation
Signed-off-by: lsytj0413 <511121939@qq.com>
| case intstr.String: | ||
| v, err := strconv.Atoi(stateObj.BatchSize.StrVal) | ||
| if err != nil { | ||
| structLevel.ReportError(reflect.ValueOf(stateObj.BatchSize), "BatchSize", "batchSize", "gt0", err.Error()) |
There was a problem hiding this comment.
I guess this gt0 stands for greater than 0, it is fine, but, in the error it will be reported like:
failed on the 'gt0' tag
It is not clear why exactly it has failed.
There was a problem hiding this comment.
I guess this gt0 stands for greater than 0, it is fine, but, in the error it will be reported like:
failed on the 'gt0' tagIt is not clear why exactly it has failed.
It's the limit of validator library, we cann't report detail message other than tag name. Maybe we can fix it later.
There was a problem hiding this comment.
maybe we could try to use another thing as tag name.
maybe the field or subfield name.
In the future we could extend the validator to override these messages, I don't know how validator works, but I guess we could extend it, right?
There was a problem hiding this comment.
Yes, if we want to custom the error message we can do this like go-playground/validator#559. I think we can create an issue for this.
Signed-off-by: lsytj0413 511121939@qq.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):
Fixed #109