Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubebuilder annotations and fix model descriptions #160

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

spolti
Copy link
Member

@spolti spolti commented Mar 10, 2023

Fixes #158

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

@ricardozanini ricardozanini changed the title Fields desc fixes Add kubebuilder annotations and fix model descriptions Mar 10, 2023
@spolti
Copy link
Member Author

spolti commented Mar 13, 2023

@ricardozanini it is ready for review.
Added somo TODOs where it needs to have some exclusive validation according to the spec.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments only! I think we need to have a way to verify if these annotations are generating the right OpenAPI and validate it in the Kubernetes API to test if it's accepted.

model/action.go Outdated Show resolved Hide resolved
model/event.go Show resolved Hide resolved
model/function.go Outdated Show resolved Hide resolved
model/workflow.go Show resolved Hide resolved
model/workflow.go Outdated Show resolved Hide resolved
model/workflow_ref.go Show resolved Hide resolved
model/workflow.go Outdated Show resolved Hide resolved
model/foreach_state.go Show resolved Hide resolved
model/event_state.go Show resolved Hide resolved
model/callback_state.go Show resolved Hide resolved
@spolti
Copy link
Member Author

spolti commented Mar 13, 2023

A few comments only! I think we need to have a way to verify if these annotations are generating the right OpenAPI and validate it in the Kubernetes API to test if it's accepted.

indeed, we can try to use kubectl or something else.

Issue created: #161

model/function.go Outdated Show resolved Hide resolved
model/workflow.go Outdated Show resolved Hide resolved
model/function.go Outdated Show resolved Hide resolved
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@6a4e16c). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage        ?   17.44%           
=======================================
  Files           ?       32           
  Lines           ?     2425           
  Branches        ?        0           
=======================================
  Hits            ?      423           
  Misses          ?     1922           
  Partials        ?       80           
Flag Coverage Δ
sdk-go 17.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Let's gooo

@ricardozanini ricardozanini merged commit d6ebe51 into serverlessworkflow:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubebuilder validations to the model structs
3 participants