-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubebuilder annotations and fix model descriptions #160
Add kubebuilder annotations and fix model descriptions #160
Conversation
@ricardozanini it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments only! I think we need to have a way to verify if these annotations are generating the right OpenAPI and validate it in the Kubernetes API to test if it's accepted.
indeed, we can try to use kubectl or something else. Issue created: #161 |
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Signed-off-by: Spolti <filippespolti@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage ? 17.44%
=======================================
Files ? 32
Lines ? 2425
Branches ? 0
=======================================
Hits ? 423
Misses ? 1922
Partials ? 80
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Signed-off-by: Spolti <filippespolti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Let's gooo
Fixes #158
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):