Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the refs exists #164

Merged
merged 15 commits into from
Jul 11, 2023
Merged

Validate the refs exists #164

merged 15 commits into from
Jul 11, 2023

Conversation

ribeiromiranda
Copy link
Collaborator

Add validator with context to validate the refs (functions, events, retries, etc) exists

@ribeiromiranda
Copy link
Collaborator Author

@ricardozanini To solve the unit test that PR (involve the default values of Function.Operation), I want to wait for PR #159.

@ribeiromiranda ribeiromiranda force-pushed the validate_exists branch 2 times, most recently from e6f724b to a7ca16f Compare March 17, 2023 02:41
@ricardozanini
Copy link
Member

#159 should be merged soon.

@ricardozanini
Copy link
Member

@ribeiromiranda any updates on this one?

@ribeiromiranda
Copy link
Collaborator Author

@ricardozanini Yes, but I didn't push it because there's a lot of unit testing to fix.

spolti
spolti reviewed May 31, 2023
View reviewed changes
model/workflow_validator.go Outdated Show resolved Hide resolved
ricardozanini
ricardozanini reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ribeiromiranda, this is awesome work. Many many thanks for this. I imagine you're still working on it, right?

Apart from that, can you join the CNCF Slack, #serverless-workflow-sdk channel? I need to talk to you. Just send me a PM. :)

model/states_validator_test.go Outdated Show resolved Hide resolved
model/workflow_validator.go
}

func init() {
// TODO: create states graph to complex check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a follow-up issue to have it documented?

model/workflow_validator.go Outdated Show resolved Hide resolved
model/workflow_validator.go Outdated Show resolved Hide resolved
model/workflow_validator.go Outdated Show resolved Hide resolved
model/workflow_validator.go Outdated Show resolved Hide resolved
@ricardozanini ricardozanini linked an issue Jun 13, 2023 that may be closed by this pull request
cyclic import between validator and model packages #151
Closed
sonatype-lift[bot]
sonatype-lift bot reviewed Jun 15, 2023
View reviewed changes
util/unmarshal.go Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

@ribeiromiranda
Copy link
Collaborator Author

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

@ricardozanini No more changes.

@ricardozanini
Copy link
Member

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

@ricardozanini No more changes.

Can you take a look at the CI errors, then? So we can merge after it. cc @spolti

@ribeiromiranda
Copy link
Collaborator Author

@ricardozanini @spolti CI errors fixed.

ricardozanini
ricardozanini approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

validator/workflow.go Outdated Show resolved Hide resolved
spolti
spolti approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice :)

@ricardozanini
Copy link
Member

Waiting for #178

@ribeiromiranda
Add validator with context to validate the refs (functions, events, r…
8816daf 
…etries, etc) exists

Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Valid errors exist and change unique_struct to unique
edcfc3e 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Fix lint
cce0955 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Add transition and compensation validations. Refactor state exists
f06a340 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Json ignore field
6dcdc3e 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Fix tests
902b1c2 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Add validations: OnEvent.EventRefs, EventCondition.EventRef, and Func…
54f6fdb 
…tionType

Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Fix tests
b4b711f 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Replace oneof to oneofkind, and improve the error message
b0556b2 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Validation refactoring for each struct to have its test case. Revisio…
cc289bc 
…n suggestions

Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Add validation oneofkind validation auth struct
164a81f 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Add new tests and improve error description
c01b2eb 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Add new unit tests, refactor intstr validator, and add new validation…
c6ba01c 
… description

Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Remove reflection from validation
67477a0 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Remove commented code
d58baa1 
Signed-off-by: André R. de Miranda <andre@galgo.tech>
@ribeiromiranda
Copy link
Collaborator Author

Waiting for #178

@ricardozanini Made the rebase with the main branch.

@ricardozanini ricardozanini merged commit 4afc5f3 into serverlessworkflow:main Jul 11, 2023
7 checks passed
@ribeiromiranda ribeiromiranda deleted the validate_exists branch July 12, 2023 01:00
@spolti spolti mentioned this pull request Aug 4, 2023
Closed
@spolti spolti mentioned this pull request Aug 28, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@ricardozanini ricardozanini ricardozanini approved these changes

@spolti spolti spolti approved these changes

Assignees
No one assigned
Labels
source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cyclic import between validator and model packages
3 participants
@ribeiromiranda @ricardozanini @spolti