Skip to content

Conversation

ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Closes #203

Special notes for reviewers:
In this PR:

  • Upgraded parser, builder, and model packages to reflect the new DSL 1.0.0
  • Removed kubernetes packages (to be added in another PR)
  • Redo validators to reflect the new API
  • New go.mod v3 to not clash with 0.8 implementation
  • Removed conv package, the integration test is now done via the Specification main branch examples
  • Added make integration-test to validate the model with the Specification examples in the main branch

Additional information (if needed):

  • I will open more issues to tackle the packages/features removed in this PR.

@ricardozanini ricardozanini requested a review from spolti January 16, 2025 22:26
@github-actions github-actions bot added documentation 📓 Improvements or additions to documentation area:kubernetes labels Jan 16, 2025
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!

I installed it and did some basic tests, everything went well
one point that might need attention is the duration validations, left a comment there.

Other small comments, but overall looks good!

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini ricardozanini added enhancement 🙏 New feature or request and removed area:kubernetes labels Jan 22, 2025
@ricardozanini ricardozanini merged commit ff500a0 into serverlessworkflow:main Jan 22, 2025
4 checks passed
@ricardozanini ricardozanini deleted the issue-203 branch January 22, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 Improvements or additions to documentation enhancement 🙏 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the SDK with the new DSL
2 participants