Changed Retry.Multiplier, OnError.Transition, OnError.End to pointer #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globalflea
changed the title
There was a problem hiding this comment.
@globalflea many thanks!
Can I ask you to sign your commit and add a test case? You will find an example here: https://github.com/serverlessworkflow/sdk-go/blob/main/parser/parser_test.go
Sure, need some time as i am not doing much during this holiday season |
|
@globalflea, can you rebase? I'd like to include this PR in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Changed Retry.Multiplier to pointer and changed min=1 (instead of min=0)
in the struct Retry.Multiplier which is a floatstr.Float32OrString, there's no way to distinguish this field as not defined. In the spec, this is supposed to be an optional field. The default struct of Float32OrString will be Type Float and the zero value of FloatVal will be a 0.0 - which will be value if the workflow json/yaml left this out.
Also, minimum of 0 does not make sense
Changed OnError.Transition & OnError.End to pointers for the same reason
Special notes for reviewers:
Additional information (if needed):