Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): update auth type to array or string #71

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(*): update auth type to array or string #71

merged 1 commit into from
Sep 8, 2022

Conversation

lsytj0413
Copy link
Collaborator

Signed-off-by: lsytj0413 511121939@qq.com

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • The auth type should be array or string

Special notes for reviewers:

Additional information (if needed):

Fixed #69

Signed-off-by: lsytj0413 <511121939@qq.com>
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, however, as I am not totally familiar with the code yet, let's wait for @ricardozanini's review :)

Btw, thanks very much for the pull request!

@ricardozanini ricardozanini added this to the Spec 0.8 Support milestone Sep 8, 2022
@ricardozanini ricardozanini merged commit 0ec04ff into serverlessworkflow:main Sep 8, 2022
@lsytj0413 lsytj0413 deleted the fix-69 branch September 9, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The top level auth property should indeed be of array or string types
3 participants