feat(eventState): add default value sequential for OnEvents.ActionMode
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Oct 5, 2022
| ActionModeParallel ActionMode = "parallel" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
is there a reason to break it into two const blocks?
There was a problem hiding this comment.
same as #97 (comment)
spolti
reviewed
Oct 5, 2022
|
@lsytj0413 can you please rebase? |
lsytj0413
changed the title
sequential for OnEvents.ActionMode
Correct the message to |
done, PTAL |
Signed-off-by: lsytj0413 <511121939@qq.com>
ricardozanini
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lsytj0413 511121939@qq.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
sequentialSpecial notes for reviewers:
Additional information (if needed):