improve validation #101
Merged
improve validation #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -388,7 +441,7 @@ private void addValidationError(String message, | |||
| private class Validation { | |||
|
|
|||
| final Set<String> events = new HashSet<>(); | |||
| final Set<String> functions = new HashSet<>(); | |||
| final Set<String> functions = new HashSet(); | |||
There was a problem hiding this comment.
unchecked: unchecked conversion
(at-me in a reply with help or ignore)
| @@ -45,7 +49,7 @@ | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(WorkflowValidatorImpl.class); | |||
| private boolean schemaValidationEnabled = true; | |||
| private List<ValidationError> validationErrors = new ArrayList<>(); | |||
| private List<ValidationError> validationErrors = new ArrayList(); | |||
There was a problem hiding this comment.
unchecked: unchecked conversion
(at-me in a reply with help or ignore)
|
@lukonjun very nice thank you!! |
tsurdilo
approved these changes
May 7, 2021
|
@lukonjun if you want to amend these 2 musedev reported comments let me know :) |
Closed
…un/sdk-java into improve-dsl-validation-81 Signed-off-by: Lucas Dario Stocksmeier <lucas@stocksmeier.de>
|
@tsurdilo musedev checks are now green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #81