Adding Google code style guide plugin #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @Override | ||
| public Constants deserialize(JsonParser jp, | ||
| DeserializationContext ctxt) throws IOException { | ||
| ObjectMapper mapper = (ObjectMapper) jp.getCodec(); |
There was a problem hiding this comment.
UnusedVariable: The local variable 'mapper' is never read.
(at-me in a reply with help or ignore)
| Object obj = yamlReader.readValue(secretsFileSrc, Object.class); | ||
| @Override | ||
| public Secrets deserialize(JsonParser jp, DeserializationContext ctxt) throws IOException { | ||
| ObjectMapper mapper = (ObjectMapper) jp.getCodec(); |
There was a problem hiding this comment.
UnusedVariable: The local variable 'mapper' is never read.
(at-me in a reply with help or ignore)
|
|
||
| ObjectMapper mapper = (ObjectMapper) jp.getCodec(); | ||
| JsonNode node = jp.getCodec().readTree(jp); | ||
| ObjectMapper mapper = (ObjectMapper) jp.getCodec(); |
There was a problem hiding this comment.
UnusedVariable: The local variable 'mapper' is never read.
(at-me in a reply with help or ignore)
|
This looks good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tihomir Surdilovic tihomir@temporal.io
adds the https://github.com/coveooss/fmt-maven-plugin plugin to maven build