Skip to content

Removing dependency from JitPack repository #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ricardozanini
Copy link
Member

Signed-off-by: Ricardo Zanini zanini@redhat.com

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
In this PR, we remove the need to have the JitPack repository declared in our POM. Some companies do not allow adding or using libraries that are not uploaded to Maven Central. It can be a problem for our community. More Info: everit-org/json-schema#360

Additional information (if needed):
The JSON Schema library is exclusively distributed via JitPack, but they also upload to Maven Central under a different artifact and group id. Although it can take some time after the initial release, it's worth not to depend on third-party repositories.

        <dependency>
            <groupId>com.github.erosb</groupId>
            <artifactId>everit-json-schema</artifactId>
            <version>1.12.1</version>
        </dependency>

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@tsurdilo tsurdilo merged commit 18241a7 into serverlessworkflow:master Jan 15, 2021
@ricardozanini ricardozanini deleted the move-jsonschema-mvn branch January 15, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants