Replacing commons-logging with slf4j in transitive dependencies #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
tsurdilo
suggested changes
Mar 17, 2021
| @@ -18,6 +18,10 @@ | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-api</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Why is this depends needed?
You could just exclude commons logging like you do below
and have the client add whatever they might need
There was a problem hiding this comment.
It's needed to give our transitive dependency the ability to log. Since they use commons-logging, it's likely that they require its interface. slf4j bridge does that: http://www.slf4j.org/legacy.html
tsurdilo
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ricardo Zanini zanini@redhat.com
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Since the most used log framework is slf4j, and we are using it in our project, it doesn't make sense to bring another logging framework to our dependency list. One of our dependencies uses
commons-logging. I just replaced it with a bridge to slf4j. So now, everything is logged using the same framework.