Skip to content

parallel exec output should be merged into one WorkflowModel #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2025
Merged

parallel exec output should be merged into one WorkflowModel #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637ed84
parallel exec output should be merged into one WorkflowModel
treblereel Oct 2, 2025
46e6632
better combined processsing
treblereel Oct 2, 2025
ff59e5d
result can be AgenticScope and Map<String, Object>
treblereel Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...tic/src/main/java/io/serverlessworkflow/impl/expressions/agentic/AgenticModelFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import io.serverlessworkflow.impl.expressions.agentic.langchain4j.AgenticScopeRegistryAssessor;
import java.time.OffsetDateTime;
import java.util.Map;
import java.util.stream.Collectors;

class AgenticModelFactory implements WorkflowModelFactory {

Expand Down Expand Up @@ -60,10 +61,11 @@ public WorkflowModel fromAny(WorkflowModel prev, Object obj) {

@Override
public WorkflowModel combine(Map<String, WorkflowModel> workflowVariables) {
// TODO: create a new agenticScope object in the AgenticScopeRegistryAssessor per branch
// TODO: Since we share the same agenticScope object, both branches are updating the same
// instance, so for now we return the first key.
return workflowVariables.values().iterator().next();
Map<String, Object> combinedState =
workflowVariables.entrySet().stream()
.map(e -> Map.entry(e.getKey(), e.getValue().asJavaObject()))
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
return newAgenticModel(combinedState);
}

@Override
Expand Down
23 changes: 20 additions & 3 deletions ...ntal/fluent/agentic/src/test/java/io/serverlessworkflow/fluent/agentic/WorkflowTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,15 @@ public void testParallel() throws ExecutionException, InterruptedException {
Map<String, String> topic = new HashMap<>();
topic.put("style", "sci-fi");

try (WorkflowApplication app = WorkflowApplication.builder().build()) {
Map<String, Object> result =
app.workflowDefinition(workflow).instance(topic).start().get().asMap().orElseThrow();

assertEquals("Fake conflict response", result.get("setting").toString());
assertEquals("Fake hero response", result.get("hero").toString());
assertEquals("Fake setting response", result.get("conflict").toString());
}

try (WorkflowApplication app = WorkflowApplication.builder().build()) {
AgenticScope result =
app.workflowDefinition(workflow)
Expand All @@ -183,9 +192,9 @@ public void testParallel() throws ExecutionException, InterruptedException {
.as(AgenticScope.class)
.orElseThrow();

assertEquals("Fake conflict response", result.readState("setting"));
assertEquals("Fake hero response", result.readState("hero"));
assertEquals("Fake setting response", result.readState("conflict"));
assertEquals("Fake conflict response", result.readState("setting").toString());
assertEquals("Fake hero response", result.readState("hero").toString());
assertEquals("Fake setting response", result.readState("conflict").toString());
}
}

Expand Down Expand Up @@ -223,6 +232,14 @@ public void testSeqAndThenParallel() throws ExecutionException, InterruptedExcep
Map<String, String> topic = new HashMap<>();
topic.put("fact", "alien");

try (WorkflowApplication app = WorkflowApplication.builder().build()) {
Map<String, Object> result =
app.workflowDefinition(workflow).instance(topic).start().get().asMap().orElseThrow();

assertEquals(cultureTraits, result.get("culture"));
assertEquals(technologyTraits, result.get("technology"));
}

try (WorkflowApplication app = WorkflowApplication.builder().build()) {
AgenticScope result =
app.workflowDefinition(workflow)
Expand Down