[Fix #863] Adding WorkflowContext and TaskContext as additional params #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s additional params User can now specify java filter functions that accepts WorkflowContext and TaskContext in their signature. Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
commented
Oct 8, 2025
| new TimeoutAfter() | ||
| .withDurationInline( | ||
| new DurationInline().withMilliseconds(10))))))) | ||
| .withOutput( |
There was a problem hiding this comment.
Output associated to a workflow, we specify the two arguments function.
Important thing to know is that TaskContext will be null if the three parameter function has been specified here (we should either document that or prevent user passing the three parameter function if the input/output/export is associated to the workflow)
fjtirado
commented
Oct 8, 2025
| .withOutput( | ||
| new Output() | ||
| .withAs( | ||
| new OutputAsFunction() |
There was a problem hiding this comment.
Output associated to the task, we call three parameter function without issue
We can also call the two/one parameter one if we want.
fjtirado
commented
Oct 8, 2025
| setObject(new TypedFunction<>(value, argClass)); | ||
| return this; | ||
| } | ||
|
|
There was a problem hiding this comment.
Export also existed ;)
ricardozanini
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can now specify java filter functions that accepts WorkflowContext and TaskContext in their signature.
Fix #863