Skip to content

Added specification standard errors #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Added specification standard errors #221

merged 3 commits into from
Jan 10, 2025

Conversation

JBBianchi
Copy link
Member

@JBBianchi JBBianchi commented Jan 10, 2025

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
This PR adds support for dynamic routes returning the specification's standard errors, formatted based on the request Accept header.

Closes #200

Special notes for reviewers:
The website isn't static anymore, therefore I added the Netlify adapter.

Additional information (if needed):

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
- Added dynamic routes to support specification errors
Notes:
- Return type based on Accept header
- Enabled SSR on netlify

Closes #200

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me! Thanks man!

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@ricardozanini
Copy link
Member

Screenshot 2025-01-10 at 10 26 49 AM

@ricardozanini ricardozanini merged commit 6cffe0e into serverlessworkflow:main Jan 10, 2025
5 checks passed
@JBBianchi JBBianchi deleted the fix-200-spec-errors branch January 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Errors namespace to the Website
3 participants