Clarify EventRef's data parameter is triggerEventRef's payload #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
ricardozanini
approved these changes
Oct 26, 2020
tsurdilo
suggested changes
Oct 26, 2020
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
tsurdilo
reviewed
Oct 26, 2020
| [Apache License version 2.0](LICENSE). |
There was a problem hiding this comment.
Wonder why both of your PRs include this change? Maybe some newline char issue?
There was a problem hiding this comment.
Yeah, it's just an additional line break vim added automatically to the end of the file.
Using od we can see the master branch has no line break:
╰─ od -c specification.md
# output omitted
0373300 W o r k f l o w s p e c i f
0373320 i c a t i o n o p e r a t e s
0373340 u n d e r t h e \n [ A p a c
0373360 h e L i c e n s e v e r s i
0373400 o n 2 . 0 ] ( L I C E N S E )
0373420 .
0373421
From this branch:
╰─ od -c specification.md
# output omitted
0373340 m d ) . \n \n # # L i c e n s e
0373360 \n \n S e r v e r l e s s W o r
0373400 k f l o w s p e c i f i c a t
0373420 i o n o p e r a t e s u n d
0373440 e r t h e \n [ A p a c h e L
0373460 i c e n s e v e r s i o n 2
0373500 . 0 ] ( L I C E N S E ) . \n
0373516
tsurdilo
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucas Caparelli lucas.caparelli112@gmail.com
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it: Clarify that EventRef's
triggerEventRefreceives the EventRef'sdataparameter as its payload.Special notes for reviewers:
Additional information (if needed): Suggestion of change from #161 discussion