Fix switch state event conditions required params + make default para… #270
Conversation
| @@ -1950,7 +1950,7 @@ Once all actions have been performed, a transition to another state can occur. | |||
| | [stateDataFilter](#state-data-filter) | State data filter | object | no | | |||
| | [onErrors](#Error-Definition) | States error handling and retries definitions | array | no | | |||
| | eventTimeout | If eventConditions is used, defines the time period to wait for events (ISO 8601 format). For example: "PT15M" (15 minutes), or "P2DT3H4M" (2 days, 3 hours and 4 minutes)| string | yes only if eventConditions is defined | | |||
| | default | Default transition of the workflow if there is no matching data conditions or event timeout is reached. Can be a transition or end definition | object | yes | | |||
| | default | Default transition of the workflow if there is no matching data conditions or event timeout is reached. Can be a transition or end definition | object | no | | |||
There was a problem hiding this comment.
Imho, if default is not provided, then we should treat it like the user specified an 'end' definition, and that the doc should be updated here to clearly call that out. On the call, the alternative idea was to say that a runtime exception should be thrown, imho these are functionally the same but 'end' seems less surprising.
There was a problem hiding this comment.
imho exception is better as modellers can catch it during testing. typically not being able to transition as wanted from a switch state is a really bad thing and masking it with an "end" (workflow termination) might be very confusing imo. wdyt?
…m not required Signed-off-by: Tihomir Surdilovic <tsurdilo@redhat.com>
tsurdilo
force-pushed
the
fixschedmaforswitchstate
branch
from
668e76a to
8a1f494
Compare
Signed-off-by: Tihomir Surdilovic <tsurdilo@redhat.com>
|
i think there were no objections to move this forward. will go ahead and merge. please feel free to sent any update prs if there are any needed. ty |
…m not required
Signed-off-by: Tihomir Surdilovic tsurdilo@redhat.com
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):