-
Notifications
You must be signed in to change notification settings - Fork 164
Remove workflowId from Parallel state #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workflowId from Parallel state #359
Conversation
@jorgenj if we are removing something from the DSL (workflowid for parallel state branches) we should mention it in the roadmap readme.md, please add it there. Also, in the specification.md for SubflowRef definition it does not say atm that it can also be a string type, just noticed, could we update that as well? Last thing I noticed was that idk how this slipped review but "waitForCompletion": {
"type": "boolean",
"default": false,
"description": "Workflow execution must wait for sub-workflow to finish before continuing"
} the default value of this should be true please. Doing anything async should be explicit choice by user. |
@jorgenj if its possible let's do a separate pr for removing the workflowid from parallel state branches. it would allow us to track this change and discuss it in meeting. |
waitForCompletion default value fixed here: #361 |
Signed-off-by: Jorgen Johnson <jorgenj@gmail.com>
@tsurdilo There's really not much in this PR except for that, so I renamed this PR to call it that and added the item in roadmap. |
@jorgenj thanks for this, |
roadmap/README.md
Outdated
@@ -27,6 +27,7 @@ _Status description:_ | |||
| ✔️| Rename switch state `default` to `defaultCondition` to avoid keyword conflicts for SDK's | [spec doc](../specification.md) | | |||
| ✔️| Add description of additional properties | [spec doc](../specification.md) | | |||
| ✔️| Rename Parallel `completionType` values | [spec doc](../specification.md) | | |||
| ✔️| Rename `workflowId` from ParallelState (use subFlow action instead) | [spec doc](../specification.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Remove" - I'll fix in a separate pr cause I think this needs to go in with us not having a meet for a while
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Will go ahead and merge this . no need to wait long time for our next meet for it |
Remove workflowId from Parallel state (use subFlow actions instead).
Signed-off-by: Jorgen Johnson jorgenj@gmail.com
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it:
I found some updates that I missed in the recent subFlowRef change that should be cleaned up. Apologies for missing this in the previous PR.
Special notes for reviewers:
Additional information (if needed):