Fix minor typo #392
Merged
Fix minor typo #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhao244
requested review from
cdavernas,
manuelstein,
ricardozanini and
tsurdilo
as code owners
cdavernas
approved these changes
May 26, 2021
yzhao244
force-pushed
the
test
branch
2 times, most recently
from
5cd9b34 to
740b8bf
Compare
Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
…sed (serverlessworkflow#349) * Update eventDataFilter to make entire cloud-event accessible. Signed-off-by: Jorgen Johnson <jorgenj@gmail.com> * Small text fixes and Roadmap update Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Co-authored-by: Jorgen Johnson <jorgen.johnson@oracle.com> Co-authored-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
…kflow#376) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
…ssworkflow#378) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
* Fix required params def for usedForCompensation Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * fix per comments Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
…ssworkflow#378) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
…ation into test Signed-off-by: Yu Zhao 00540916 <yu.zhao5@huawei.com>
|
Hello, I have a few PRs failed on DCO check. After running "git commit --amend --no-edit --signoff" suggested by DCO details, still didn't sign commit c137dca. :( .. Should I close this PR and start a new fresh one? |
|
its fine dont worry about it now. maybe we can try again for future ones.
…On Wed, May 26, 2021 at 4:36 PM yuri ***@***.***> wrote:
Hello, I have a few PRs failed on DCO check. After running "git commit
--amend --no-edit --signoff" suggested by DCO details, still didn't sign
commit c137dca
<c137dca>.
:( .. Should I close this PR and start a new fresh one?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#392 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5E7XVJQ6ANISHG777V2LTPVLWPANCNFSM45SNXVPA>
.
|
@tsurdilo thx :) |
ricardozanini
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it:
I think our reviewer's name was added in specification. :)
Special notes for reviewers:
Additional information (if needed):