Skip to content

Improve state execution timeouts #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2021

Conversation

tsurdilo
Copy link
Contributor

@tsurdilo tsurdilo commented Jun 22, 2021

Signed-off-by: Tihomir Surdilovic tihomir@temporal.io

Many thanks for submitting your Pull Request ❤️!

Please specify parts this PR updates:

  • [ x] Specification
  • [x ] Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

What this PR does / why we need it:

  • Improves state execution timeout property:
    • Adds ability to set "single" and "total" properties meaning that you can define the max execution timeout per state execution excluding / including retries.

Special notes for reviewers:

Additional information (if needed):

@tsurdilo
Copy link
Contributor Author

@cdavernas @manuelstein @ricardozanini let me know if this raises any questions.

@tsurdilo tsurdilo added the area: spec Changes in the Specification label Jun 22, 2021
@cdavernas
Copy link
Member

@tsurdilo I'm off until Friday, will review it in detail and bring some comments of our DM discussions along with it asap ;)

@tsurdilo
Copy link
Contributor Author

@cdavernas sounds good

@tsurdilo tsurdilo added this to the v0.7 milestone Jul 2, 2021
tsurdilo added 4 commits July 11, 2021 00:20
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
@tsurdilo tsurdilo force-pushed the improvestatestimeout branch from 9e99450 to 7d0ff42 Compare July 11, 2021 04:20
@tsurdilo
Copy link
Contributor Author

rebased

@tsurdilo tsurdilo merged commit 47b9de9 into serverlessworkflow:main Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: spec Changes in the Specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants