Adding sleep object type prop to action definitions #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsurdilo
requested review from
cdavernas,
manuelstein and
ricardozanini
as code owners
tsurdilo
changed the title
cdavernas
approved these changes
Aug 7, 2021
tsurdilo
changed the title
|
@cdavernas updated to add the "sleep" type which has "before" and "after" props. this is so it matches the changes introduced in #439 (delay --> sleep) |
ricardozanini
approved these changes
Aug 9, 2021
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
tsurdilo
force-pushed
the
sleepinfunctions
branch
from
541e4cc to
7ea4d41
Compare
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
tsurdilo
added a commit
to tsurdilo/specification
that referenced
this pull request
Aug 9, 2021
…ow#440) * Adding sleepBefore and sleepAfter to function definitions Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * moved props from functionDef to actionDef Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * updated roadmap Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * created 'sleep' type instead of individual props Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
tsurdilo
added a commit
that referenced
this pull request
Aug 9, 2021
* Rename Delay state to Sleep state and rename timeDelay to duration property (#439) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Adding sleep object type prop to action definitions (#440) * Adding sleepBefore and sleepAfter to function definitions Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * moved props from functionDef to actionDef Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * updated roadmap Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * created 'sleep' type instead of individual props Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Fix Car Vitals example (#443) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Adding rate limiting extension (#442) * Adding rate limiting extension Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * update readme Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Foreach State - adding sequential exec option and batchSize for paral… (#441) * Foreach State - adding sequential exec option and batchSize for parallel exec option Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * updated roadmap Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
yzhao244
pushed a commit
to yzhao244/specification
that referenced
this pull request
Jul 19, 2024
* Rename Delay state to Sleep state and rename timeDelay to duration property (serverlessworkflow#439) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Adding sleep object type prop to action definitions (serverlessworkflow#440) * Adding sleepBefore and sleepAfter to function definitions Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * moved props from functionDef to actionDef Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * updated roadmap Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * created 'sleep' type instead of individual props Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Fix Car Vitals example (serverlessworkflow#443) Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Adding rate limiting extension (serverlessworkflow#442) * Adding rate limiting extension Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * update readme Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Foreach State - adding sequential exec option and batchSize for paral… (serverlessworkflow#441) * Foreach State - adding sequential exec option and batchSize for parallel exec option Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * updated roadmap Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Update specification.md Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tihomir Surdilovic tihomir@temporal.io
Many thanks for submitting your Pull Request ❤️!
Please specify parts this PR updates:
What this PR does / why we need it:
Often you want to add a sleep before/after function invocations. Adding "sleep" property to actiondef that
allows you to define these sleeps (in action definitions).
Special notes for reviewers:
Additional information (if needed):