Unify end and transition parameters #651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasdavidorg
requested review from
antmendoza,
cdavernas,
ricardozanini and
tsurdilo
as code owners
ricardozanini
approved these changes
Jul 29, 2022
tsurdilo
added
the
change: documentation
|
@tomasdavidorg merged some of your other prs before this one ..need rebase, sry. |
tomasdavidorg
force-pushed
the
end-transition-unification
branch
from
b8c8dd9 to
7e9360a
Compare
Signed-off-by: Tomas David <tdavid@redhat.com>
tomasdavidorg
force-pushed
the
end-transition-unification
branch
from
7e9360a to
e4a997f
Compare
|
@tsurdilo I will open a new PR. Need to do some more fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas David tdavid@redhat.com
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does / why we need it:
End parameter could be
booleanorobjectand transition parameter could bestringorobject. This PR unifies their definitions across the workflow states.Special notes for reviewers:
Additional information: