Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stateName type #654

Merged
merged 1 commit into from Aug 9, 2022
Merged

Conversation

tomasdavidorg
Copy link
Contributor

@tomasdavidorg tomasdavidorg commented Aug 9, 2022

Signed-off-by: Tomas David tdavid@redhat.com

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Roadmap
  • Use Cases
  • Community
  • TCK
  • Other

Discussion or Issue link:

What this PR does / why we need it:

StateName is presented as a string in the example and not as an object.

{
  "stateName": "MyStartingstate",
  "schedule": "2020-03-20T09:00:00Z/PT2H"
}

Special notes for reviewers:

Additional information:

Signed-off-by: Tomas David <tdavid@redhat.com>
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks!

@tsurdilo tsurdilo added the documentation Improvements or additions to documentation label Aug 9, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Aug 9, 2022
@tsurdilo tsurdilo merged commit 8e758ec into serverlessworkflow:main Aug 9, 2022
@tomasdavidorg tomasdavidorg deleted the stateNameType branch August 10, 2022 06:02
tomasdavidorg added a commit to tomasdavidorg/specification that referenced this pull request Aug 22, 2022
Signed-off-by: Tomas David <tdavid@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants