-
Notifications
You must be signed in to change notification settings - Fork 61
[UI] Footer created - first iteration #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Nikhil-Ladha @leecalcote Nailed the layout, need to make it responsive and refactor the code. |
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Nikhil-Ladha need to change the social icons, other than that anything else? |
🚀 Preview for commit 19a6dd7 at: https://62f107ebe9b20f6f983aacb0--service-mesh-patterns.netlify.app |
The opacity of the text beneath the "patterns" icon and the |
Also, the footer is not responsive. Please take care of that. |
@Rohith-Raju updates on this? |
@Nikhil-Ladha was caught up with catalog. Will do it by EOD |
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Nikhil-Ladha I'll handle responsiveness after we finalize the design |
@Nikhil-Ladha Any more changes to consider ? |
🚀 Preview for commit 9ce0907 at: https://62fe7e3e0a65851206c4a744--service-mesh-patterns.netlify.app |
Update the title, sublinks, and the description below the logo colors similar to what we have for the layer site. |
Also, the logos should have a hover effect similar to the layer5 site. |
@leecalcote is that iPad ?, cause I haven't added media queries. Looks fine in mine |
Sure @Nikhil-Ladha |
On it @Nikhil-Ladha |
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Rohith-Raju Safari on desktop |
@leecalcote oh, ok I"ll look into it |
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Nikhil-Ladha @leecalcote added responsiveness |
For the n-th time please fix the sub-items and description text color 🙏🏼 |
🚀 Preview for commit 352b59b at: https://6316eeb948c9b818dc09c44e--service-mesh-patterns.netlify.app |
Signed-off-by: rohith-raju <rohithraju488@gmail.com>
Signed-off-by: Rohith-Raju rohithraju488@gmail.com
Description
Created the first iteration of the footer as per the design requirements
This PR fixes #55
Notes for Reviewers
As this is the first iteration, pr requires to be refactored.
Signed commits