Skip to content

Conversation

Rohith-Raju
Copy link
Contributor

Signed-off-by: Rohith-Raju rohithraju488@gmail.com

Description
Created the first iteration of the footer as per the design requirements

This PR fixes #55

Notes for Reviewers
As this is the first iteration, pr requires to be refactored.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Rohith-Raju
Copy link
Contributor Author

@Nikhil-Ladha @leecalcote Nailed the layout, need to make it responsive and refactor the code.
image

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Rohith-Raju
Copy link
Contributor Author

Rohith-Raju commented Aug 7, 2022

@Nikhil-Ladha need to change the social icons, other than that anything else?

@l5io
Copy link
Contributor

l5io commented Aug 8, 2022

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha need to change the social icons, other than that anything else?

The opacity of the text beneath the "patterns" icon and the resources needs to be reduced. Similar to what we have for layer5.io.

@Nikhil-Ladha
Copy link
Contributor

Also, the footer is not responsive. Please take care of that.

@Nikhil-Ladha
Copy link
Contributor

@Rohith-Raju updates on this?

@Rohith-Raju
Copy link
Contributor Author

@Nikhil-Ladha was caught up with catalog. Will do it by EOD

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Rohith-Raju
Copy link
Contributor Author

@Nikhil-Ladha I'll handle responsiveness after we finalize the design

@Rohith-Raju
Copy link
Contributor Author

@Nikhil-Ladha Any more changes to consider ?

@l5io
Copy link
Contributor

l5io commented Aug 18, 2022

@Nikhil-Ladha
Copy link
Contributor

Update the title, sublinks, and the description below the logo colors similar to what we have for the layer site.

@leecalcote
Copy link
Member

Screenshot of latest deploy preview. 😬
Screen Shot 2022-08-18 at 1 05 25 PM

@Nikhil-Ladha
Copy link
Contributor

Also, the logos should have a hover effect similar to the layer5 site.
The height of the Subscribe button is not equal to the input field.
The copyright text font-size should be smaller compared to other links.

@Rohith-Raju
Copy link
Contributor Author

Screenshot of latest deploy preview. 😬 Screen Shot 2022-08-18 at 1 05 25 PM

@leecalcote is that iPad ?, cause I haven't added media queries. Looks fine in mine
image

@Rohith-Raju
Copy link
Contributor Author

Update the title, sublinks, and the description below the logo colors similar to what we have for the layer site.

Sure @Nikhil-Ladha

@Rohith-Raju
Copy link
Contributor Author

Also, the logos should have a hover effect similar to the layer5 site. The height of the Subscribe button is not equal to the input field. The copyright text font-size should be smaller compared to other links.

On it @Nikhil-Ladha

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@leecalcote
Copy link
Member

@Rohith-Raju Safari on desktop

@Rohith-Raju
Copy link
Contributor Author

@leecalcote oh, ok I"ll look into it

Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
Signed-off-by: Rohith-Raju <rohithraju488@gmail.com>
@Rohith-Raju
Copy link
Contributor Author

@Nikhil-Ladha @leecalcote added responsiveness
image
image

@Nikhil-Ladha
Copy link
Contributor

For the n-th time please fix the sub-items and description text color 🙏🏼

@l5io
Copy link
Contributor

l5io commented Sep 6, 2022

Signed-off-by: rohith-raju <rohithraju488@gmail.com>
@Rohith-Raju Rohith-Raju closed this Sep 7, 2022
@Rohith-Raju Rohith-Raju deleted the footer branch September 7, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Site] Add the footer section
4 participants