Support Guid[] as TVP parameters
#405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snaumenko-st
approved these changes
Aug 27, 2025
| #endregion | ||
|
|
||
|
|
||
| public static readonly FrozenSet<Type> TypesWithTvpSupport = [typeof(int), typeof(long), typeof(Guid), typeof(string)]; |
There was a problem hiding this comment.
we should probably also add support for int type separately from long. Otherwise there is conversion operation involved in SQL runtime to convert from one to another, and performance of such queries can be much worse.
There was a problem hiding this comment.
For general purposes, yes
But in practice, the app almost never uses int lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have TVP support of
IEnumerable<long>&IEnumerable<string>in.In()expressions.This change adds
IEnumerable<Guid>support, as filtering by GUID list is used in a few places in the App