Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Make noise when a build machine's job is taking longer than 1 hour #75

Closed
jdm opened this issue Jan 23, 2018 · 12 comments
Closed

Make noise when a build machine's job is taking longer than 1 hour #75

jdm opened this issue Jan 23, 2018 · 12 comments

Comments

@jdm
Copy link
Member

jdm commented Jan 23, 2018

We can learn about current build jobs on our machines by fetching http://build.servo.org/json/slaves?as_text=1. One example shows that sevo-linux-cross3 has been running for more than 2 hours: https://gist.github.com/jdm/ae1be5ef10ef308f9fdc93856a0515e0 . We should query this information every 30 minutes and squawk loudly if any build machine is stuck.

@carlosmcgregor
Copy link

Hello, @jdm ! Can I take over this issue?

@jdm
Copy link
Member Author

jdm commented Feb 2, 2018

Please do! Ask questions if anything is unclear!

@jdm
Copy link
Member Author

jdm commented Feb 14, 2018

@carlosmcgregor Have you made any progress with this?

@carlosmcgregor
Copy link

Thank you for your patience! I have my test IRC server running and I have been playing around with crowbot commands. I am also reviewing its code so that I do not add unnecessary lines. I hope to be done by the end of the weekend, if that's alright.

@carlosmcgregor
Copy link

@jdm Just making sure: the alert needs to go off for builds that have past their ETA.

@jdm
Copy link
Member Author

jdm commented Feb 15, 2018

@carlosmcgregor I would say if a build is >30 minutes past the ETA, it would be worth alerting about the fact.

@carlosmcgregor
Copy link

@jdm I am pretty much done, but I am missing the squawking part. Could you please hint me in the direction of how to send sounds via IRC? I read about the /sound command, but I could not find a resource talking about how to enact this via node-irc.

@jdm
Copy link
Member Author

jdm commented Feb 15, 2018

Sorry, by squawk I just meant send a message to the channel that gets attention.

@carlosmcgregor
Copy link

Oh okay! Sorry, I'm new to crowbot so I'm still getting used to the terms used here. Would this channel be #servo? Also, is it necessary for me to add test cases?

Sorry if I'm asking too many questions!

@jdm
Copy link
Member Author

jdm commented Feb 16, 2018

You can follow the example of this code which uses the first channel from the configuration file as the target. And a test case would be nice to have, if it doesn't require too many awkward internal changes to support. This project uses mocha, and you can find the tests in tests/server.test.js, and run them with npm test.

@carlosmcgregor
Copy link

Thank you! That's the code I was using. I will be making a pull request right now.

jdm added a commit that referenced this issue Feb 20, 2018
Solves issue #75 (i.e. squawk when ETA > .5)
@jdm
Copy link
Member Author

jdm commented Mar 9, 2018

This was fixed by #76 and #79.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants