Remove imports of enum variants in xml5ever/tokenizer/states.rs

[simonwuelker]

states.rs has a really weird import pattern: The module defines a couple of different enums, mainly XmlState which defines tokenizer states, like XmlState::Data.
It then does pub(crate) use XmlState::*; and the rest of the crate uses either states::XmlState or states::Data to refer to either the enum or its variants respectively.

This is confusing, so this PR removes the wildcard imports.

tokenizer.rs still has some wildcard imports but those are really annoying to remove because the go! macro DSL of the state machine relies on them...

[nicoburns]

Are these wildcard imports meant to still be there?

[simonwuelker]

Yes, these are slightly more difficult to remove.

[nicoburns]

This looks like it ought to be breaking, but https://docs.rs/xml5ever/latest/xml5ever/tokenizer/states/index.html doesn't show any types. So I assume these were not actually public even though they were pub used

[simonwuelker]

This looks like it ought to be breaking, but https://docs.rs/xml5ever/latest/xml5ever/tokenizer/states/index.html doesn't show any types. So I assume these were not actually public even though they were pub used

No you're right, these are public. They're not shown on docs.rs because the enums in the latest published version are annotated with #[doc(hidden)]. My bad.