Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipc-channel to 0.16 #395

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Update ipc-channel to 0.16 #395

merged 1 commit into from
Jun 25, 2023

Conversation

mukilan
Copy link
Member

@mukilan mukilan commented Jun 24, 2023

ipc-channel used in servo needs to bumped to 0.16.1 to complete servo/servo#29467, but that requires the same version to be used by media crates as well.

FYI: I had accidentally pushed my change to master branch of this repo. I've now force pushed master to it's previous state. I've also made 'master' a protected branch. Please let me know if that needs to be changed or removed.

Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
@jdm
Copy link
Member

jdm commented Jun 24, 2023

This looks fine, but apparently webrender no longer builds on nightly rust :(

@mukilan
Copy link
Member Author

mukilan commented Jun 24, 2023

@jdm looks like only the example code uses webrender, specifically v0.60.0 which is quite old and the offending code has been removed in servo/webrender@e8d2d7d6

I am able to build and run servo master with latest ipc-channel (plus your patch and another small change to account for the renaming of drain_filter nightly feature flag.

Do you think we should first publish webrender 0.62.0 and update the failing examples or should we merge this PR now and fix the examples in a new issue?

cc @mrobinson as you know more about webrender

@jdm
Copy link
Member

jdm commented Jun 24, 2023

Ah, if it's just example code than I'm less concerned. I'm ok with merging and fixing up the example separately.

@mukilan
Copy link
Member Author

mukilan commented Jun 25, 2023

I've created this issue to update the example with new webrender.

I'll merge this PR manually for now.

@mukilan mukilan merged commit b6969ae into master Jun 25, 2023
@mukilan mukilan deleted the update-to-ipc-channel-0.16 branch June 25, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants