Also respect readelf and objcopy cc-rs variants #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
changed the title
jschwe
changed the title
|
Just adding |
sagudev
approved these changes
Jun 15, 2024
While compiling servo for OpenHarmony on a MacOS host, I noticed that readelf and objcopy apparently aren't chosen from the same directory as the clang c compiler, but needed to be in PATH for the configure script to pick them up. To allow users to set READELF and OBJCOPY explicitly, we should also read the relevant cc-rs environment variables. An alternative would have been to inspect the configure scripts and find out why they don't look next to clang, but I'm not familiar enough with the configure script.
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling servo for OpenHarmony on a MacOS host, I noticed that readelf and objcopy apparently aren't chosen from the same directory as the clang c compiler, but needed to be in PATH for the configure script to pick them up. To allow users to set READELF and OBJCOPY explicitly, we should also read the relevant cc-rs environment variables.
An alternative would have been to inspect the configure scripts and find out why they don't look next to clang, but I'm not familiar enough with the configure script.